Skip to content

test: prepare test-whatwg-encoding-* to be ported to WPT if possible

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/prepare-encoding-tests into master

test: split test-whatwg-encoding-textdecoder.js

Split test-whatwg-encoding-textdecoder.js into:

  • test-whatwg-encoding-custom-textdecoder.js which tests Node.js-specific behaviors
  • test-whatwg-encoding-custom-textdecoder-api-invalid-label.js which is a customized version of the WPT counterpart
  • test-whatwg-encoding-custom-api-basics.js which is the part of test-whatwg-encoding-api-basics.js that can be run without ICU
  • test-whatwg-encoding-api-basics.js which can be replaced with WPT later.

test: split test-whatwg-encoding-textdecoder-fatal.js

Split test-whatwg-encoding-textdecoder-fatal.js into

  • test-whatwg-encoding-custom-textdecoder-fatal.js which is a customized version of the WPT that tests for Node.js-specific error codes.
  • test-whatwg-encoding-custom-textdecoder-invalid-arg which tests ERR_INVALID_ARG_TYPE

test: split encoding tests where some cases can be run without ICU

test: rename custom encoding tests that cannot be replaced by WPT

test: add TODO to encoding tests that can be replaced with WPT

Split the following tests:

  • test-whatwg-encoding-textdecoder-utf16-surrogates.js
  • test-whatwg-encoding-textdecoder-ignorebom.js
  • test-whatwg-encoding-textdecoder-streaming.js

Each into two files: one that can be run without ICU and one that has to be run with ICU. The latter can be replaced with WPT later.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports