Skip to content

test: fix test-repl-envvars

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/test-repl-envvars-no-extend into master

In 180f8650, the test was changed so that the env argument of createInternalRepl() also contained external environment variables, because keeping them can be necessary for spawning processes on some systems.

However, this test does not spawn new processes, and relies on the fact that the environment variables it tests are not already set (and fails otherwise); therefore, reverting to the original state should fix this.

Fixes: https://github.com/nodejs/node/issues/21451 Fixes: https://github.com/nodejs/build/issues/1377 Refs: https://github.com/nodejs/node/pull/25219

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports