Skip to content

test: set umask for tests

Rodrigo Muino Tomonari requested to merge github/fork/Trott/tmpdir-umask into master

https://github.com/nodejs/node/pull/25213 proposes setting umask in the Python test runner to avoid spurious test failures when running from a shell with a restrictive umask. This is a good idea, but will only fix the issue for tests run with the Python runner. Set it in common/index.js as well so that it fixes it even when tests are run directly with a node binary, bypassing the Python test runner.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports