Skip to content

lib: simplify several debug() calls

Rodrigo Muino Tomonari requested to merge github/fork/cjihrig/debug into master

Avoid calling Array.prototype.join() in debug() calls. These are evaluated on every call, even if the debug() call is a no-op. This commit replaces the join() calls with the %j placeholder.

As a general note, we should probably migrate the codebase to using printf() style placeholders, and avoid template strings and string concatenation in debug() calls. It might be a good Code and Learn activity. The http2 module is a particularly bad offender.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports

Loading