Skip to content

test: remove common.allowGlobals

Rodrigo Muino Tomonari requested to merge github/fork/BridgeAR/remove-globals-check into master

This removes the globals check that was executed in all tests so far. Instead just rely on the explicit globals test to verify that the globals did not leak.

We have dedicated tests for the globals (/test/parallel/test-global.js) which load all modules up front to make sure we definitely get all code which might add globals.

This test is very old and comes from times where we neither had code reviews nor good tests. Now we have both and I don't think we should run this code on each test file anymore.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports