Skip to content

src: reduce includes of node_internals.h

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/reduce-internals into master

At the moment node_internals.h serves as a header for declarations of internal APIs that do not have their own headers, so it includes many other headers for internal types and is subject to frequent changes, which often trigger recompilations of files that include node_internals.h and creates a lot of indirect dependencies on unnecessary headers.

This patch moves the utilities in node_internals.h that only depends on v8.h into util.h, and reduce the number of includes of node_internals.h across the code base - most of them can be replaced with util.h or env-inl.h instead.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports