Skip to content

test: do not assume tls handshake order

Rodrigo Muino Tomonari requested to merge github/fork/sam-github/cleanup-tls-test-shutdown into master

These are a number of cleanups to the TLS test suites that I noticed while trying to run the tests with TLS1.3, but they aren't specific to TLS1.3. I'd like them off my branch so its clear they are equally applicable to TLS1.2, that is, they are not API breaking changes being introduced with TLS1.3.

Mostly they involve removing assumptions about the relative ordering of client and server TLS handshake completion, graceful use of .end() to tear down tests (rather than destroy), and some conversions of tests to use common.mustCall()

PTAL @nodejs/crypto

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports