Skip to content

test: change ciphers from 'RC4' to 'no-such-cipher'

Rodrigo Muino Tomonari requested to merge github/fork/danbev/test-tls-handshake-error-rhel8 into master

This commit updates option ciphers from 'RC4' to 'no-such-cipher' in test/parallel/test-tls-handshake-error.js.

The motivation for this change is that this test is verifying that a 'no ciphers match' error be thrown, but 'RC4' might be among the ciphers supported by the OpenSSL version when dynamically linking. I ran into this specific issue when dynamically linking against OpenSSL 1.1.1 on RHEL8 using https://github.com/nodejs/node/pull/25381.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports