Skip to content

process: check env->EmitProcessEnvWarning() last

Rodrigo Muino Tomonari requested to merge github/fork/bcoe/fix-process-warn into master

Calling env->EmitProcessEnvWarning() prevents additional warnings from being set it should therefore be called only if a warning will emit.

Split this work out from https://github.com/nodejs/node/pull/25157, addressing @joyeecheung's concerns.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports

Loading