Skip to content

src: properly configure default heap limits

Rodrigo Muino Tomonari requested to merge github/fork/ofrobots/default-max-heap-size into master

Unless configured, V8 defaults to limiting the max heaps size to 700 MB or 1400MB on 32 and 64-bit platforms respectively. This default is based on the browser use-cases and doesn't make a lot of sense generally. This change properly configures the heap size based on actual available memory.

This should reduce the number of instances where we run out of memory processing larger data-sets. It is still possible to pass --max-old-space-size to use a different limit.

CI: https://ci.nodejs.org/job/node-test-pull-request/20203/ CI: https://ci.nodejs.org/job/node-test-pull-request/20310/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports