Skip to content

os: implement os.release() using uv_os_uname()

Rodrigo Muino Tomonari requested to merge github/fork/cjihrig/os-release into master

Ignore the first commit, which is the yet to be merged libuv 1.25.0 update.

For non-Windows platforms, the happy path behavior should be identical. On Windows, uv_os_uname() attempts to use RtlGetVersion() before falling back to the deprecated GetVersionExW() that Node was previously using. This could lead to some Windows users seeing a different value for os.release() after this change. Technically, this is a bug fix, but I'd also understand if some collaborators are in favor of marking this semver-major.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports