Skip to content

test: remove setTimeout from https renegotiation test

Rodrigo Muino Tomonari requested to merge github/fork/Trott/no-timers-plz into master

Replace a setTimeout() with an arbitrary-ish 50ms delay with immediate calls to the relevant function in test-https-ci-reneg-attack. Arbitrary timers are often a cause for unreliable tests, especially on very fast or very slow platforms, as they create race conditions. Regardless if that's the case here, the timer is unnecessary.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports

Loading