Skip to content

src: invoke per-isolate setters earlier

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/move-setters into master

This patch moves the invocation of:

  • SetHostInitializeImportMetaObjectCallback
  • SetHostImportModuleDynamicallyCallback
  • SetPromiseRejectCallback

and the DTrace-related:

  • AddGCPrologueCallback(DTraceGCStartCallback)
  • AddGCEpilogueCallback(DTraceGCEndCallback).

into node::NewIsolate(), and moves the performance-timeline-related:

  • AddGCPrologueCallback(performance::MarkGarbageCollectionStart)
  • AddGCEpilogueCallback(performance::MarkGarbageCollectionEnd)

that needs per-Environment data into the Environment constructor, instead of scattering the initialization code around in bindings.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports