Skip to content

build,python: update flake8 rules

Rodrigo Muino Tomonari requested to merge github/fork/refack/float-patch-wpt into master

xrange does not exist in python3 hence it's lint blocking https://github.com/nodejs/build/issues/1631, but it is not used in our codebase. As I see it we have 3 options to unblock:

  1. float a patch and wait for https://github.com/web-platform-tests/wpt/pull/14973
  2. clean up directory of dead code
  3. ignore in https://github.com/nodejs/node/blob/f698386c7e988ef45027a75b2ff988899ee2af1d/Makefile#L1294-L1297

Personally, I prefer option 1.

/CC @nodejs/testing @nodejs/python

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports