Skip to content

test: rewrite fs {f}utimes test file

Rodrigo Muino Tomonari requested to merge github/fork/Fishrock123/fix-fs-utimes-test into master

Previously this test silently swallowed some errors. Hint: That giant callback stack.

Refactored to use common.mustCall() & assert()s.

Also, this adds a couple of extra error-checking cases.

Ugh I'm sorry about this one. I've been meaning to do it forever. (I tired to get someone else to do it as their first PR and that never panned out.)

Anyways this was originally discovered as part of https://github.com/lionheart/openradar-mirror/issues/19944

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

CI: https://ci.nodejs.org/job/node-test-pull-request/20276/

Merge request reports