Skip to content

WIP src: print stack of Error object with --abort-on-uncaught-exception

Rodrigo Muino Tomonari requested to merge github/fork/mmarchini/abort-on-uncaught-print-error-stack into master

DO NOT LAND YET. This depends on an upstream pull request: https://chromium-review.googlesource.com/c/v8/v8/+/1412115

When --abort-on-uncaught-exception is set and an exception is thrown but uncaught, V8 will print the stack trace of the crash site right before exiting. This behavior differs from the default, which will print the stack trace of the thrown error object. This is especially problematic when we're crashing because of a rethrown error.

These changes use a new signature for the AbortOnUncaughtExceptionCallback which also receives the Message and Error objects to print the Error stack trace before aborting.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports