Skip to content

test: remove s_client from test-tls-ci-reneg-attack

Rodrigo Muino Tomonari requested to merge github/fork/Trott/rm-client into master

Rewrite test-tls-ci-reneg-attack to use tls.renegotiate() instead of external (and potentially unpredictable/quirky/buggy) s_client.

Refs: https://github.com/nodejs/node/pull/25676#issuecomment-457307881

This test is currently broken (due to a quirk in a recent s_client update that we haven't worked around yet, see Ref above) and this change fixes it. The test is only run once a day in CI (because it's in pummel) so the breakage went unnoticed when the OpenSSL update landed a few days ago. A subsequent PR could probably move this test out of pummel. It seems like it could reasonably run in sequential or maybe even parallel.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports