Skip to content

src: in-source comments and minor TLS cleanups

Rodrigo Muino Tomonari requested to merge github/fork/sam-github/tls-cleanups into master

Renamed some internal C++ methods and properties for consistency, and commented SSL I/O.

  • Rename waiting_new_session_ after is_waiting_new_session(), instead of using reverse naming (new_session_wait_).
  • Make TLSWrap::ClearIn() return void, the value is never used.
  • Fix a getTicketKeys() cut-n-paste error. Since it doesn't use the arguments, remove them from the js wrapper.

This is semver-patch, none of the changes are visible, not even at the binding layer.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports