Skip to content

[v8.x-backport] build: skip cctest on Windows shared lib build

Rodrigo Muino Tomonari requested to merge github/fork/BethGriggs/backport-21228-to-v8.x into v8.x-staging

Backport to resolve simple conflict and to ensure this change makes it into v8.x.

cctest depends on some internal APIs which don't declare __declspec(dllexport) and causes build failure when building node as shared lib on Windows. Since we already have good test coverage in static lib, we decide to skip the cctest in shared lib build on Windows.

Signed-off-by: Yihong Wang yh.wang@ibm.com

PR-URL: https://github.com/nodejs/node/pull/21228 Reviewed-By: Refael Ackermann refack@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports