Skip to content

src: make deleted functions public in node.h

Rodrigo Muino Tomonari requested to merge github/fork/gengjiawen/refactor_node.h into master

Expert from Effective Modern C++ Items 11: Prefer deleted functions to private undefined ones

By convention, deleted functions are declared public, not private. There’s a reason for that. When client code tries to use a member function, C++ checks accessibility before deleted status. When client code tries to use a deleted private function, some compilers complain only about the function being private, even though the function’s accessibility doesn’t really affect whether it can be used. It’s worth bearing this in mind when revising legacy code to replace private-and-not-defined member functions with deleted ones, because making the new functions public will generally result in better error messages.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports