Skip to content

src: add handle scope to `OnFatalError()`

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/report-fatal-error-handle-scope into master

For the report generation, we use Environment::GetCurrent(isolate) which uses isolate->GetCurrentContext() under the hood, thus allocates a handle. Without a HandleScope, this is invalid.

This might not strictly be allowed inside of OnFatalError(), but it won’t make anything worse either.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports