Skip to content

lib: move signal event handling into bootstrap/node.js

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/signal-handlers into master

Moves the process.on() and promise.emit() calls happened during bootstrap for signal events into bootstrap/node.js so it's easier to tell the side effects.

Drive-by changes:

  • Moves the signal event re-arming to a point later during the bootstrap - as early as it were it's unlikely that there could be any existing signal events to re-arm for node-report.
  • Use a Map instead of an Object for signal wraps since it is used as a deletable dictionary anyway.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports