Skip to content

report: catch internal segfaults

Rodrigo Muino Tomonari requested to merge github/fork/gireeshpunathil/sigsegv into master

--diagnostic-report-on-fatalerror does not capture internal segfaults at present, instead limited to only faults that are detected by the Node / v8. libuv's signal handler deliveres result asynchronously which does not help for SIGSEGV as: i) the synchronous sequence restarts the failing code, ii) due to i) the callback is never delivered to the consumer.

Install a SIGSEGV handler in Node and follow the sequence of fatalerror handling, as of now at least under report.

Fixes: https://github.com/nodejs/node/issues/25762

cc @addaleax @sam-github @bnoordhuis

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports