Skip to content

[v10.x] src: dispose of V8 platform in `process.exit()`

Rodrigo Muino Tomonari requested to merge github/fork/MylesBorins/backport-25061 into v10.x-staging

Calling process.exit() calls the C exit() function, which in turn calls the destructors of static C++ objects. This can lead to race conditions with other concurrently executing threads; disposing of all Worker threads and then the V8 platform instance helps with this (although it might not be a full solution for all problems of this kind).

Refs: https://github.com/nodejs/node/issues/24403 Refs: https://github.com/nodejs/node/issues/25007

PR-URL: https://github.com/nodejs/node/pull/25061 Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com Reviewed-By: Joyee Cheung joyeec9h3@gmail.com Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

Merge request reports