Skip to content

src: move req_wrap_queue to base class of ReqWrap

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/req-wrap-queue into master

Introduce a second base class for ReqWrap that does not depend on a template parameter and move the req_wrap_queue_ field to it.

This addresses undefined behaviour that occurs when casting to ReqWrap<uv_req_t> in the ReqWrap constructor.

Refs: https://github.com/nodejs/node/issues/26131

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports