Skip to content

process: delay signal handler setup to pre-execution and skip them in workers

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/move-signal into master

process: setup signal handler in prepareMainThreadExecution

Because this is only necessary in the main thread. Also removes the rearming of signal events since no signal event handlers should be created during the execution of node.js now that we've made the creation of stdout and stderr streams lazy - this has been demonstrated in the test coverage.

process: move initialization of node-report into pre_execution.js

  • Splits signal handler setup code into two functions: one sets up process.on('SIGNAL_NAME'), another takes care of the signal triggers of node-report. Both should only happen on the main thread. The latter needs to happen after the node-report configurations are read into the process.
  • Move the initialization of node-report into pre_execution.js because it depends on CLI/environment settings.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports