Skip to content

src: reduce to simple `const char*` in OptionsParser

Rodrigo Muino Tomonari requested to merge github/fork/zys-contrib/src-node-options into master

As the comment said:

TODO(addaleax): A lot of the std::string usage here could be reduced to simple const char*s if it's reasonable to expect the values to be known at compile-time.

So this commit uses const char* to replace most of std::string in OptionsParser and remove the TODO.

/cc @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports