Skip to content

test: eliminate port collision in test-cluster-net-listen-ipv6only-rr

Rodrigo Muino Tomonari requested to merge github/fork/gireeshpunathil/rr into master

In test test-cluster-net-listen-ipv6only-rr, the cluster member that listens to any port actually has the potential to grab any port from the environment which when passed onto the master causes collision when it tries to listen on.

Moving the test to sequential alone is not sufficient as the cluster member can in theory catch on to the admin ports on the host.

Assigning static port alone is also not sufficient, as it can interfere with other running tests in the parallel category which would be mostly running with port: any fashion.

So move to sequential, and use a static port.

Fixes: https://github.com/nodejs/node/issues/25813

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports