Skip to content

http: only destroy socket once error is sent

Rodrigo Muino Tomonari requested to merge github/fork/yannh/clean_conn_close_on_client_error into master

This patch fixes the race condition: sometimes the socket is destroyed before the data is sent. If node is proxied by, for example, an AWS ELB, a 504 error would be returned instead of the expected 400.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports