Skip to content

http: send connection: close on client error

Rodrigo Muino Tomonari requested to merge github/fork/yannh/add_required_header_on_client_error into master

HTTP/1.1 mandates connections which do not support keep-alive and close the connection send the connection: close header, see https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.10

This page also provides more information: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection

I understand that HTTP/1.1 defaults to keep-alive - and that the Connection: close header is required when closing a connection.

This adds the Connection: close header in the 400 and 414 responses sent on client errors.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports