Skip to content

dtrace: move DTRACE_* probes out of global scope

Rodrigo Muino Tomonari requested to merge github/fork/jasnell/dtrace-not-global into master

The DTRACE_* probes have been global for no really good reason. Move those into an internalBinding.

This is semver-major because it removes the DTRACE_* functions from the global scope. They are still used via the internalBinding. Note that this is without doing a deprecation. Not doing a deprecation should be safe because these are (a) undocumented, (b) only enabled when dtrace is enabled (it's off by default), (c) there's zero evidence that any userland code uses these, (d) support for DTrace/ETW is Best-Effort.

/cc @nodejs/diagnostics @nodejs/tsc

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports