Skip to content

fs: allow int64 offset in fs.read/readSync/write/writeSync

Rodrigo Muino Tomonari requested to merge github/fork/zbjornson/zb/26563 into master

Since v10.10.0, 'buf' can be any DataView, meaning the largest byteLength can be Float64Array.BYTES_PER_ELEMENT * kMaxLength = 17,179,869,176.

Fixes #26563 (closed)

Eventually, the same change applies to fs.write*. If this current change is acceptable, I'll make the corresponding change there. Done

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included - No. I can add a test but I don't see a way to do it without requiring a large amount of disk space and memory. benchmark N/A.
  • documentation is changed or added - No. If this is significant enough to note in the history section, let me know.
  • commit message follows commit guidelines

Merge request reports