Skip to content

timers: refactor timer callback initialization

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/refactor-timers into master

timers: refactor to use module.exports

timers: reduce usage of public util

Refs: https://github.com/nodejs/node/issues/26546

timers: refactor timer callback initialization

This patch:

  • Moves the timer callback initialization into bootstrap/node.js, documents when they will be called, and make the dependency on process._tickCallback explicit.
  • Moves the initialization of tick callbacks and timer callbacks to the end of the bootstrap to make sure the operations done before those initializations are synchronous.
  • Moves more internals into internal/timers.js from timers.js.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports