Skip to content

stdio: make stdout and stderr emit 'close' on destroy

Rodrigo Muino Tomonari requested to merge github/fork/mcollina/fix-26550 into master

The problem in #26550 (closed) was caused by net.Socket having set emitClose: false  because it was emitted its own event in _destroy(), and stdio.js was overriding _destroy without emitting 'close'.

Fix: https://github.com/nodejs/node/issues/26550

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports