Skip to content

process: deprecate toStringTag assignment

Rodrigo Muino Tomonari requested to merge github/fork/guybedford/process-tostringtag-deprecate into master

As a follow-on to #26488 this makes writing to process[Symbol.toStringTag] a full deprecation in Node.js.

Most intrinsics with Symbol.toStringTag set (eg Promise.prototype), have this as non-writeable, so it seems to make sense that process should do the same.

I'm not strongly set on this by any means either if anyone has reasons against it (perhaps the warnings will turn out more annoying than the strict error previously!).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports