Skip to content

console: remove unreachable code

Rodrigo Muino Tomonari requested to merge github/fork/Trott/console-table-unreachable into master

The current version of lib/internal/console/constructor.js includes this as part of line 470:

setlike ? iterKey : indexKey

However, setlike is guaranteed to be true because we are inside of an if block (starting on line 463) that explicitly checks that setlike is true.

Coverage reporting confirms that setlike is always true when it is reached in our tests.

Remove the ternary as the value provided will always be iterKey.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports