Skip to content

deps: float node-gyp process.release change

Rodrigo Muino Tomonari requested to merge github/fork/rvagg/float-node-gyp-3 into master
  • support process.release
  • support all io.js versions
  • support node v4+ including new download locations
  • enable delay-load hook by default by default
  • download header-only tarballs instead of full source

See nodejs/node-gyp#711 for full details.

The plan is to float this in the initial v4 release and possibly shortly thereafter and then get it in to npm when they are comfortable with it and all our problems will be solved and there will be world peace. My PR bundles https://github.com/nodejs/node/pull/2699 and https://github.com/nodejs/node/pull/2696 so it assumes those are merged prior.

The relevant commit to review here is ddf1bfb but what I've done is: cd deps/npm && npm i 'node-gyp@nodejs/node-gyp#process.release' -S which has pulled in some additional things that are not in 2.0.2 but some of which do seem to be in npm so I'm not sure exactly what's going on there. @zkat I probably need you and @othiym23 to confirm that it's going to be fine to use semver@5 that's coming with npm, https://github.com/nodejs/node-gyp/pull/664 says it's "low risk"; it's removed semver@4 from the tree and is using npm's bundled version.

Merge request reports