Skip to content

benchmark: remove deprecated argument

Rodrigo Muino Tomonari requested to merge github/fork/Trott/no-dep-bench into master

The benchmarks for dns.lookup() include calling it with an empty hostname which results in a deprecation warning. This benchmark seems to be subject to some odd side effects (see Ref below) and we probably generally don't want to benchmark deprecated things by default anyway. Remove the deprecated value from the default list. Bonus is that this will speed up the benchmark.

Refs: https://github.com/nodejs/node/pull/27081#issuecomment-479981874

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports