Skip to content

worker: handle exception when creating execArgv errors

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/worker-check into master

Handle possible JS exceptions that can occur by returning to JS land immediately.

The motivation for this change is that USE(….FromJust()); is an anti-pattern, and .FromJust() with an unused return value is superseded by .Check(). However, in this case, checking that the operation succeeded is not necessary.

Refs: https://github.com/nodejs/node/pull/27162

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports