Skip to content

src: prefer v8::Global over node::Persistent

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/persistent2global into master

v8::Global is essentially a nicer variant of node::Persistent that, in addition to reset-on-destroy, also implements move semantics.

This commit makes the necessary replacements, removes node::Persistent and (now-)unnecessary inclusions of the node_persistent.h header, and makes some of the functions that take Persistents as arguments more generic so that they work with all v8::PersistentBase flavours.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports