Skip to content

http: `servername === false` should disable SNI

Rodrigo Muino Tomonari requested to merge github/fork/indutny/feature/disable-sni into master

There is no way to disable SNI extension when sending a request to HTTPS server. Setting options.servername to a falsy value would make Node.js core override it with either hostname or ip address.

This change introduces a way to disable SNI completely if this is required for user's application. Setting options.servername to false in https.request would disable overrides and thus disable the extension.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports