Skip to content

test: improve test-async-hooks-http-parser-destroy

Rodrigo Muino Tomonari requested to merge github/fork/Trott/simplify-test into master

Improve reporting in test-async-hooks-http-parser-destroy when failing.

Before, failures looked like this (edited slightly to conform to our commit message 72-char line length restriction):

The expression evaluated to a falsy value:
assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)

Now, you get a slightly better idea of what's up. (Is it missing one ID? More than one? All of them?):

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected ... Lines skipped

  [
    156,
...
    757,
-   761,
    765
  ]
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports