Skip to content

src: reduce env.h & env-inl.h include lines

Try this PR to resolve #27531 (closed):

  • confirm the forward declaration to support Environment* in "env.h":

https://github.com/nodejs/node/blob/3b48ce6ccfb39b72a446fad06b56d29dabe09b05/src/env.h#L414

  • remove the include lines of env.h & env-inl.h in src/, while pass make -j4 test
    • list of files that I couldn't remove (could use advice if any suggest to update further)
      • env.h:
        • node_crypto.h, node_dtrace.h, node_messaging.h, string_bytes.h
      • env-inl.h:
        • base_object-inl.h, debug_utils.h, node_binding.cc, node_config.cc, node_domain.cc, node_errors.h, node_internals.h, node_native_module_env.cc, node_options.cc, node_os.cc, node_process_events.cc, node_symbols.cc, node_types.cc, node_v8.cc, string_decoder.cc, timers.cc, uv.cc, async_resource.cc, encoding.cc
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports

Loading