tools: force common be required before any other modules (!27650) · Merge requests · Rodrigo Test / Test Group-nodejs / node · GitLab

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Rodrigo Muino Tomonari requested to merge github/fork/zys-contrib/eslint-require-common into master May 11, 2019

Add a new eslint rule require-common-first to enforce common be loaded in tests before any other modules.

The common module should be required in tests before any other module: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#lines-1-3

Refs: https://github.com/nodejs/node/pull/27455#discussion_r279222145

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines