Skip to content

inspector: supported NodeRuntime domain in worker

Rodrigo Muino Tomonari requested to merge github/fork/alexkozy/worker-node-runtime-support into master

NodeRuntime domain was introduced to give inspector client way to fetch captured information before Node process is gone. We need similar capability for worker.

With current protocol inspector client can force worker to wait on start by passing waitForDebuggerOnStart flag to NodeWorker.enable method. So client has some time to setup environment, e.g. start profiler. At the same time there is no way to prevent worker from being terminated. So we can start capturing profile but we can not reliably get captured data back.

This PR implemented NodeRuntime.notifyWhenWaitingForDisconnect method for worker. When NodeRuntime.waitingForDisconnect notification is enabled, worker will wait for explicit NodeWorker.detach call.

With this PR worker tooling story is nicely aligned with main thread tooling story. The only difference is that main thread by default is waiting for disconnect but worker thread is not waiting.

Issue: https://github.com/nodejs/node/issues/27677

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports