Skip to content

deps: V8: cherry-pick cca9ae3c9a

Rodrigo Muino Tomonari requested to merge github/fork/bnoordhuis/fix27667 into master

Original commit message:

Remove recursion from NeedsCheckHeapObject.

We use the predicate NeedsCheckHeapObject in the compiler frontend to
determine whether we can skip introducing CheckHeapObject nodes. But
this predicate would also walk up the graph in case of Phis, which can
result in really long compilation times (on the main thread). In the
report in https://github.com/nodejs/node/issues/27667, the compiler
frontend alone took around 4-5mins of main thread time for a single
function. With this patch the time goes down to 4-5ms.

Bug: v8:9250
Refs: nodejs/node#27667
Change-Id: I231eb780ff04f949fa1669714f9af6ebfbcade05
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1612897
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61503}

Fixes: https://github.com/nodejs/node/issues/27667

Per the issue, this applies to v10.x-v12.x. v8.x is unaffected.

Merge request reports