Skip to content

src: only run preloadModules if the preload array is not empty

Rodrigo Muino Tomonari requested to merge github/fork/MarshallOfSound/perf/preload-modules into master

Noticed this while doing some performance work on Electrons start-up time, it looks like the getOptionValue call here always returns a truthy value even when it is an empty array. When it's empty we can shortcut a require call here saving a few ms 👍

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports