Skip to content

src: use String::NewFromUtf8 in ProcessEmitWarningGeneric

Rodrigo Muino Tomonari requested to merge github/fork/codebytere/clean-processemitgeneric into master
Description of Change

Previously, the new warning string in ProcessEmitWarningGeneric was allocated using String::NewFromUtf8, but type and warning, despite also being const char*, were instead allocated using String::NewFromOneByte. I couldn't find a semantic reason for using differing string allocation functions, so this PR improves consistency by using String::NewFromUtf8 for all three.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports