Skip to content

test: move --cpu-prof tests to sequential

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/cpu-prof-sequential into master

The tests still fail after being split into multiple files, (2 out of 30 runs in roughly 48 hours) and the causes are missing target frames in the samples. This patch moves them to sequential to observe if the flakiness can be fixed when the tests are run on a system with less load.

If the flake ever shows up again even after the tests are moved to sequential, we should consider make the tests more lenient - that is, we would only assert that there are some frames in the generated CPU profile but do not look for the target function there.

Refs: https://github.com/nodejs/node/issues/27611

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports