Skip to content

build: fix cctest target for --without-report

Rodrigo Muino Tomonari requested to merge github/fork/richardlau/fix-without-report into master

Conditionally build test/cctest/test_report_util.cc only when configured to include the diagnostic report feature.

Fixes the following link error when configured with --without-report:

/home/users/riclau/sandbox/github/nodejs/out/Release/obj.target/cctest/test/cctest/test_report_util.o: In function `ReportUtilTest_EscapeJsonChars_Test::TestBody()':
test_report_util.cc:(.text+0x57): undefined reference to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
test_report_util.cc:(.text+0x1ad): undefined reference to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
test_report_util.cc:(.text+0x302): undefined reference to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
test_report_util.cc:(.text+0x44a): undefined reference to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
test_report_util.cc:(.text+0x592): undefined reference to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
/home/users/riclau/sandbox/github/nodejs/out/Release/obj.target/cctest/test/cctest/test_report_util.o:test_report_util.cc:(.text+0xd7a): more undefined references to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)' follow
collect2: error: ld returned 1 exit status
make[1]: *** [/home/users/riclau/sandbox/github/nodejs/out/Release/cctest] Error 1

cc @nodejs/build-files

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports